[FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …

[lirui-apache]

…when creating a result

What is the purpose of the change

Fix the issue that types with parameters, e.g. decimal, cannot be accessed via SQL client.

Brief change log

• Avoid the conversion between DataType and TypeInformation for CollectBatchTableSink and CollectStreamTableSink.

Verifying this change

Will add test cases later on.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? NA

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1446d68 (Wed Sep 11 18:27:05 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❗ 3. Needs [attention] from.
  • Needs attention by @docete
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• d78dad6 : SUCCESS Build
• 9f19670 : SUCCESS Build
• 53ef1e1 : CANCELED Build
• 8ff9bc9 : UNKNOWN
• 1446d68 : FAILURE Build

[bowenli86]

the JIRA ticket mentioned that "As a result, querying a Hive table with decimal column from SQL CLI will hit the following exception", can we add a test showing the problem is covered now?

[lirui-apache]

the JIRA ticket mentioned that "As a result, querying a Hive table with decimal column from SQL CLI will hit the following exception", can we add a test showing the problem is covered now?

We can't because we don't have integration tests for LocalExecutor and Hive connector ...

[bowenli86]

@KurtYoung @docete can you take a look?

[bowenli86]

@flinkbot attention @docete

[lirui-apache]

Managed to add tests to verify this PR works with both new and old type systems.
@bowenli86 @xuefuz @zjuwangg please have a look. Thanks.

[xuefuz]

PR looks good to me.

[lirui-apache]

Updated to revert unnecessary changes.
@bowenli86 Please take a look. Thanks.

[bowenli86]

LGTM, merging