[FLINK-13799][web]: fix error message web submit is disables in the c…

[vthinkxie]

…onfig

What is the purpose of the change

fix https://issues.apache.org/jira/browse/FLINK-13799

Brief change log

there is no method to get if web.submit.enable is false in rest API

I hide the jar error message from rest by modifying the frontend interceptor

Verifying this change

If you put web.submit.enable: false into the configuration, no errors will continuously pop up.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 291ac11 (Wed Oct 16 08:36:12 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[sorahn]

LGTM

[flinkbot]

CI report:

• 291ac11 : FAILURE Build

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build

[zentol]

While this does cover the case of multiple error messages when accessing the page, the user still gets odd error messages if he tries to use the submit page in any way.

If we want to backport the proper solution (See subtasks of FLINK-13799) to 1.9, then I would skip this PR.
If we don't want to backport it, then we need a more extensive fix imo.

[vthinkxie]

the upload button in the submit page is already hidden when getting the error message, so the user could not use the submit page in the case.
I think we should wait for the proper solution if not hurry.

[vthinkxie]

Hi @zentol
I found that the web can get web.submit.enable from the jobmanager configuration, is that correct to judge if the submit is enabled from the key web.submit.enable?

[zentol]

@vthinkxie FLINK-13817 exposes whether submissions are enabled in a more reliable way. The configuration is is unreliable since it only lists explicitly configured keys; if the key is not explicitly configured you'd have to make assumptions on the default.

[zentol]

I will close this PR for the time being. If we do not manage to implement the approach outlined in FLINK-13818 in time for a release we can fallback on this proposal.