Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-13799][web]: fix error message web submit is disables in the c… #9504

Closed
wants to merge 1 commit into from
Closed

[FLINK-13799][web]: fix error message web submit is disables in the c… #9504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion flink-runtime-web/web-dashboard/src/app/app.interceptor.ts
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ export class AppInterceptor implements HttpInterceptor {
* Error response from below url should be ignored
*/
const ignoreErrorUrlEndsList = ['checkpoints/config', 'checkpoints'];
const ignoreErrorMessage = ['File not found.'];
const ignoreErrorMessage = ['File not found.', 'Unable to load requested file /jars.'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does cover the case of multiple error messages when accessing the page, the user still gets odd error messages if he tries to use the submit page in any way.

If we want to backport the proper solution (See subtasks of FLINK-13799) to 1.9, then I would skip this PR.
If we don't want to backport it, then we need a more extensive fix imo.

Copy link
Contributor Author

@vthinkxie vthinkxie Aug 23, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the upload button in the submit page is already hidden when getting the error message, so the user could not use the submit page in the case.
I think we should wait for the proper solution if not hurry.

return next.handle(req).pipe(
catchError(res => {
const errorMessage = res && res.error && res.error.errors && res.error.errors[0];
Expand Down