Issue 923 #940
Issue 923 #940
Conversation
default ScannerBuilder over(Bytes row) {...}
default ScannerBuilder over(CharSequence row) {...}
default ScannerBuilder over(Bytes row, Column col){...}
default ScannerBuilder over(CharSequence row, , Column col){...}
default ScannerBuilder overPrefix(Bytes row) {...}
default ScannerBuilder overPrefix(CharSequence row){...}
default ScannerBuilder overPrefix(Bytes row, Column col){...}
default ScannerBuilder overPrefix(CharSequence row, , Column col){...}
…prefix() methods ScannerIT WeakNotificationIT WorkerIT FluoIT LogIT
| @@ -30,6 +31,96 @@ | |||
| */ | |||
| ScannerBuilder over(Span span); | |||
|
|
|||
| /** | |||
| * | |||
| * @since 1.2.0 | |||
There was a problem hiding this comment.
When javadoc is rendered, I think it usually puts the since info at the end. As a result, its my personal pref is put the since tag at the end of the javadoc source. Don't need to change if you don't agree.
| @@ -464,7 +464,7 @@ public void testRange() throws Exception { | |||
| HashSet<Column> columns = new HashSet<>(); | |||
|
|
|||
| CellScanner cellScanner = | |||
| tx2.scanner().over(Span.exact(Bytes.of("d00001"))).fetch(new Column("outlink")).build(); | |||
| tx2.scanner().over(Bytes.of("d00001")).fetch(new Column("outlink")).build(); | |||
There was a problem hiding this comment.
Could remove Bytes.of and just have over("d00001"). The calls to Bytes.of are from a time when support for Strings didn't exist everywhere in the API. This was a pre-existing problem, does not have to be fixed in this PR.
| * @param colPrefix restrict the scanner to data in {@link org.apache.fluo.api.data.Column} that begins with a prefix | ||
| * @return self | ||
| */ | ||
| default ScannerBuilder overPrefix(Bytes rowPrefix, Column colPrefix) { |
There was a problem hiding this comment.
Need to change rowPrefix to row.
| * | ||
| * @since 1.2.0 | ||
| * @see org.apache.fluo.api.data.Span#prefix(Bytes, Column) | ||
| * @param rowPrefix restrict the scanner to data in rows that begins with a prefix |
There was a problem hiding this comment.
This method scans a column prefix within an exact row. So, need to change rowPrefix to row. Also the javadoc should say something like restrict the scanner to data in specified row.
| * @since 1.2.0 | ||
| * @see org.apache.fluo.api.data.Span#prefix(Bytes, Column) | ||
| * @param rowPrefix restrict the scanner to data in rows that begins with a prefix | ||
| * @param colPrefix restrict the scanner to data in {@link org.apache.fluo.api.data.Column} that begins with a prefix |
There was a problem hiding this comment.
Could say restrict scanner to data that begins with specified column prefix
| * @param colPrefix restrict the scanner to data in {@link org.apache.fluo.api.data.Column} that begins with a prefix | ||
| * @return self | ||
| */ | ||
| default ScannerBuilder overPrefix(CharSequence rowPrefix, Column colPrefix) { |
There was a problem hiding this comment.
need to make same changes for rowPrefix to row
Changed param rowPrefix to row, and updated javadocs for the following methods:
overPrefix(Bytes, Column){...}
overPrefix(CharSequence, Column){...}
Removed use of Bytes.of(String) calls within over() calls from FloutIT tests
| @@ -463,8 +463,7 @@ public void testRange() throws Exception { | |||
|
|
|||
| HashSet<Column> columns = new HashSet<>(); | |||
|
|
|||
| CellScanner cellScanner = | |||
| tx2.scanner().over(Span.exact(Bytes.of("d00001"))).fetch(new Column("outlink")).build(); | |||
| CellScanner cellScanner = tx2.scanner().over("d00001").fetch(new Column("outlink")).build(); | |||
There was a problem hiding this comment.
This looks a lot nicer.
|
@jkosh44 there is a javadoc error, you can see this in the Travis build. Javadoc is only built on demand. Travis is configured to build it. You can build it locally with the following commands. mvn clean package javadoc:aggregate
# if builds, then following command can display it
firefox target/site/apidocs/index.html |
|
I restarted the travis build and it passed, so I merged it. Thanks again @jkosh44 |
No description provided.