Geode-6054: Build with VS2017 and new gtest #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
- No longer need the D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING workaround for VS 2017
jake-at-work
requested changes
Nov 28, 2018
|
All requested changes completed. |
jake-at-work
approved these changes
Nov 28, 2018
|
Agreed. Should I close this PR for now? |
|
No. I would just get a PR open for the image so others can test this change. As is there’s is no guidance on how to build a viable VS 2017 environment. After that PR is accepted then you could merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.