Closed
Conversation
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
jake-at-work
requested changes
Nov 21, 2018
Contributor
jake-at-work
left a comment
jake-at-work
left a comment
There was a problem hiding this comment.
The CMAKE_CXX_FLAGS and compile definitions added need to be addressed differently. See comments inline.
Contributor
Author
|
Thanks pivotal-jbarrett for a diligent review! All changes have been implemented. |
Contributor
|
Can you explain why you are changing the exception handling mode? How is it interacting with the .NET library since this exception mode is not supported for /clr? https://msdn.microsoft.com/en-us/library/ffkc918h.aspx
Strikes me that mixing exception modes is dangerous. |
Contributor
Author
|
I think some new Warnings as Errors shows up with the new (and likely stricter compiler). I will forward to you as soon as I finish this episode of Ozark. Not sure about using a different exception model between the managed and unmanaged sides.
… On Nov 21, 2018, at 7:21 PM, Jacob Barrett ***@***.***> wrote:
Can you explain why you are changing the exception handling mode? How is it interacting with the .NET library since this exception mode is not supported for /clr?
The following compiler options are not supported with /clr:
/EHsc and /EHs (/clr implies /EHa (see /EH (Exception Handling Model))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
We were seeing a C4530 Warning:
https://msdn.microsoft.com/en-us/library/2axwkyt4.aspx
But I can't reproduce it. Trying a build without the /EHsc. Also, it seems
like this would be the default for unmanaged but I can't find docs on that.
…On Wed, Nov 21, 2018 at 8:51 PM Michael Martell ***@***.***> wrote:
I think some new Warnings as Errors shows up with the new (and likely
stricter compiler). I will forward to you as soon as I finish this episode
of Ozark. Not sure about using a different exception model between the
managed and unmanaged sides.
On Nov 21, 2018, at 7:21 PM, Jacob Barrett ***@***.***>
wrote:
Can you explain why you are changing the exception handling mode? How is
it interacting with the .NET library since this exception mode is not
supported for /clr?
The following compiler options are not supported with /clr:
/EHsc and /EHs (/clr implies /EHa (see /EH (Exception Handling Model))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#407 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP6jXyrJoR90QvPlCf1ADBanlXJp5qUNks5uxhgegaJpZM4YsIuG>
.
|
Contributor
Author
|
Reverted the change to a different exception model. All issues addressed with latest commit. |
jake-at-work
requested changes
Nov 26, 2018
dependencies/gtest/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| if(WIN32) | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -m64 /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING") |
Contributor
There was a problem hiding this comment.
Why -m64 here?
The /D would be handled in a target definitions call and not cxx flags.
| project(framework LANGUAGES CXX) | ||
|
|
||
| #IF(MSVC) | ||
| # SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc") |
| ) | ||
|
|
||
| #IF(MSVC) | ||
| # SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc") |
- No longer need the D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING workaround for VS 2017
|
@mmartell if this has stalled you might consider closing the PR until ready for review again... |
jake-at-work
requested changes
Nov 27, 2018
| set( DEPENDENCIES_${PROJECT_NAME}_DIR ${${PROJECT_NAME}_BINARY_DIR} PARENT_SCOPE) | ||
|
|
||
| if(MSVC) | ||
| set(CMAKE_STATIC_LIBRARY_SUFFIX "$<$<CONFIG:Debug>:d>${CMAKE_STATIC_LIBRARY_SUFFIX}") |
Contributor
Author
|
This is being replaced by PR #411. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.