GEODE-7235: Add backwards compatibility for Clang #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Oleske <moleske@pivotal.io>
- One of the new flags added for Clang 11 support was not available to earlier versions Co-authred-by: Michael Oleske <moleske@pivotal.io>
pdxcodemonkey
requested changes
Oct 4, 2019
CMakeLists.txt
Outdated
| @@ -191,8 +191,12 @@ if (NOT HAVE_STDC_FORMAT_MACROS) | |||
| target_compile_definitions(c++11 INTERFACE __STDC_FORMAT_MACROS) | |||
| endif() | |||
|
|
|||
| if ("Darwin" STREQUAL ${CMAKE_SYSTEM_NAME} ) | |||
| set(DISABLED_MAC_WARNINGS -Wno-defaulted-function-deleted -Wno-c++2a-compat) | |||
| if(${CMAKE_CXX_COMPILER_ID} STREQUAL "AppleClang") | |||
There was a problem hiding this comment.
Below, we set ignored compiler warnings based on the following test:
if(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
if that check works, we should be able to use the same one here, and change the variable name to something like CONDITIONALLY_DISABLED_CLANG_WARNINGS, a lot more generic than "AppleClang" and MAC.
There was a problem hiding this comment.
Come to think of it, we could/should check and disable these warnings separately, for correctness' sake.
- moved to if statement already checking complier is clang Co-authored-by: Michael Oleske <moleske@pivotal.io> Co-authored-by: Ivan Godwin <igodwin@pivotal.io>
pdxcodemonkey
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Michael Oleske moleske@pivotal.io