GEODE-8754: Fix uninitialized variable in DataInput::ReadInternalObject #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CompositeClassWithClassAsKey
- Also update instantiators for new classes
|
This pull request introduces 4 alerts when merging 2b2e388 into 5f14294 - view on LGTM.com new alerts:
|
echobravopapa
requested changes
Dec 2, 2020
- cleanup dead code - add ClassAsKey test - fix LGTM alerts
jake-at-work
approved these changes
Dec 3, 2020
echobravopapa
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an uninitialized variable in the clicache code (DataInput::ReadInternalObject). Also, added a new serialization test (CompositeClassWithClassAsKey) since there were no existing tests that executed this function.