GEODE-10044: Allow FunctionAttributes update #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rationale behind this change is allowing the server function upgrade scenario, which was previously discussed in here: https://www.mail-archive.com/dev@geode.apache.org/msg26144.html |
|
This pull request introduces 1 alert when merging 2fad8a9 into 9aa78f4 - view on LGTM.com new alerts:
|
gaussianrecurrence
force-pushed
the
feature/GEODE-10044
branch
5 times, most recently
from
e1d681d
to
7faabf2
Compare
gaussianrecurrence
force-pushed
the
feature/GEODE-10044
branch
4 times, most recently
from
9caac3d
to
7e8f736
Compare
- Moved FunctionExecution and OnRegionFunctionExecution into a separate file in order to improve readability and code maintenance. - Moved ChunkedFunctionExecutionResponse into a separate file in order to improve readability and code maintenance. - Introduced FunctionAttributes class to improve code readability. - Modified code to introduce the usage of FunctionAttributes. - Modified TcrMessageTest UT to work with the inclusion of FunctionAttributes. - Implemented a mechanism to cleanup function attributes. - A new exception FunctionAttributesMismatchException is added to be thrown whenever the server detects a mismatch for the function attributes. - Now whenever FunctionAttributesMismatchException is catched while executing a function, its function attributes are cleaned up, so the client will request an update the next execution. - Added new ITs to verify that chaging a function attributes on the fly is possible. - Re-enabled and fixed TcrMessageTest.testConstructorExecuteFunction to ensure TcrMessageExecuteFunction is constructed as expected.
gaussianrecurrence
force-pushed
the
feature/GEODE-10044
branch
from
7e8f736
to
a75a86c
Compare
|
I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file in order to improve readability and code maintenance.
to improve readability and code maintenance.
FunctionAttributes.
thrown whenever the server detects a mismatch for the function
attributes.
executing a function, its function attributes are cleaned up, so the
client will request an update the next execution.
fly is possible.