Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-6063 remove PublishArtifacts from Geode release pipelines #2865

Conversation

onichols-pivotal
Copy link
Contributor

This PR will resolve the red job on the release/1.8.0 pipeline. Releases should only be signed and published manually, so unlike develop branch which publishes a snapshot automatically after every successful build, release pipelines do not need publish step at all.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • [n/a] Does gradlew build run cleanly?

  • [n/a] Have you written or updated unit tests to verify your changes?

  • [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

- UpdatePassingRef
{%- endif %}
{%- if repository.upstream_fork != "apache" or repository.branch == "develop" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will only not PublishArtifacts if we are on apache on a branch that is not develop. Seems reasonable enough to assume that's a release branch. Do we ever build with a repo that is not apache?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe on a fork?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downstream consumers of the pipeline may publish their releases without the manual process Apache Geode goes through.

@nonbinaryprogrammer
Copy link
Contributor

nonbinaryprogrammer commented Nov 16, 2018

IntegrationTestOpenJDK11 failed with known flaky test with stacktrace:
org.apache.geode.distributed.ServerLauncherRemoteFileIntegrationTest > startDeletesStaleControlFiles FAILED java.lang.IllegalStateException: Status file '/tmp/junit2902603449106298011/vf.gf.server.status' is blank

DistributedTestOpenJDK8 failed with known flaky test GEODE-5655 with stacktrace:
org.apache.geode.session.tests.Jetty9ClientServerTest > containersShouldShareDataRemovals FAILED org.codehaus.cargo.container.ContainerException: Failed to stop the Jetty 9.4.12.v20180830 container. Check the [/home/geode/geode/geode-assembly/build/distributedTest133/cargo_logs/JETTY9_client-server_containersShouldShareDataRemovals_0_1136207203814/container.log] file containing the container logs for more details. Caused by: org.codehaus.cargo.container.ContainerException: Server port 21900 did not shutdown within the timeout period [120000]

@nonbinaryprogrammer nonbinaryprogrammer merged commit 4c8ebf8 into apache:develop Nov 16, 2018
nonbinaryprogrammer pushed a commit to nonbinaryprogrammer/geode that referenced this pull request Nov 16, 2018
@onichols-pivotal onichols-pivotal deleted the GEODE-6063-dont-try-to-publish-from-release-pipeline branch August 27, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants