Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-6063 remove PublishArtifacts from Geode release pipelines #2865

Merged
merged 1 commit into from
Nov 16, 2018
Merged

GEODE-6063 remove PublishArtifacts from Geode release pipelines #2865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ci/pipelines/geode-build/jinja.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ groups:
jobs:
- {{ build_test.name }}
{{- all_gating_jobs() | indent(2) }}
{%- if repository.sanitized_fork == repository.upstream_fork %}
{%- if repository.sanitized_fork == "apache" and repository.branch == "develop" %}
- UpdatePassingRef
{%- endif %}
{%- if repository.upstream_fork != "apache" or repository.branch == "develop" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will only not PublishArtifacts if we are on apache on a branch that is not develop. Seems reasonable enough to assume that's a release branch. Do we ever build with a repo that is not apache?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe on a fork?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downstream consumers of the pipeline may publish their releases without the manual process Apache Geode goes through.

- PublishArtifacts
{%- endif %}
- name: complete
Expand All @@ -104,8 +106,10 @@ groups:
- {{test.name}}Test{{java_test_version.name}}
{%- endfor -%}
{%- endfor -%}
{%- if repository.sanitized_fork == repository.upstream_fork %}
{%- if repository.sanitized_fork == "apache" and repository.branch == "develop" %}
- UpdatePassingRef
{%- endif %}
{%- if repository.upstream_fork != "apache" or repository.branch == "develop" %}
- PublishArtifacts
{%- endif %}
- name: linux
Expand Down Expand Up @@ -313,7 +317,7 @@ jobs:
- name: instance-data
timeout: 1h

{% if repository.sanitized_fork == repository.upstream_fork %}
{% if repository.sanitized_fork == "apache" and repository.branch == "develop" %}
- name: UpdatePassingRef
public: true
serial: true
Expand All @@ -336,6 +340,8 @@ jobs:
- name: geode-ci
outputs:
- name: results
{% endif %}
{% if repository.upstream_fork != "apache" or repository.branch == "develop" %}
- name: PublishArtifacts
public: true
plan:
Expand Down