GEODE-7055: Don't send failure replies from a P2P reader thread #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were hitting a deadlock during startup if a P2P reader thread tried to send a failure reply - it would block waiting for startup to finish, but startup would not finish until the P2P reader thread could read a startup response. Send the failure reply in a separate thread, to make sure we always unblock the P2P reader thread to read new messages.
bschuchardt
reviewed
Aug 7, 2019
bschuchardt
approved these changes
Aug 8, 2019
upthewaterspout
deleted the
feature/deadlock-on-failure-reply-GEODE-7055
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hitting a deadlock during startup if a P2P reader thread tried
to send a failure reply - it would block waiting for startup to finish,
but startup would not finish until the P2P reader thread could read a
startup response.
Send the failure reply in a separate thread, to make sure we always
unblock the P2P reader thread to read new messages.