GEODE-6944: add support for *REDUNDANT* regionType #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Darrel Schneider <dschneider@pivotal.io> * we can create a region config object using a shortcut, but can not set it after it's created * regionType is a more distilled enum that more corresponds to data policy now * the converter will recognize more region types created by gfsh or cache.xml
dschneider-pivotal
requested changes
Aug 21, 2019
...main/java/org/apache/geode/management/internal/configuration/converters/RegionConverter.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/geode/management/internal/configuration/converters/RegionConverter.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/geode/management/internal/configuration/converters/RegionConverter.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/geode/management/internal/configuration/converters/RegionConverter.java
Outdated
Show resolved
Hide resolved
geode-management/src/main/java/org/apache/geode/cache/configuration/RegionType.java
Outdated
Show resolved
Hide resolved
geode-management/src/main/java/org/apache/geode/management/configuration/Region.java
Outdated
Show resolved
Hide resolved
geode-management/src/main/java/org/apache/geode/management/configuration/RegionShortcut.java
Outdated
Show resolved
Hide resolved
jinmeiliao
changed the title
dschneider-pivotal
requested changes
Aug 26, 2019
...main/java/org/apache/geode/management/internal/configuration/converters/RegionConverter.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/geode/management/internal/configuration/validators/RegionConfigValidator.java
Outdated
Show resolved
Hide resolved
dschneider-pivotal
approved these changes
Aug 26, 2019
|
This pull request introduces 1 alert when merging 732692b into 6549e25 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0705714 into 6549e25 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Darrel Schneider dschneider@pivotal.io