GEODE-7358: Membership code should use InternalDistributedMember as the membership identifier #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 02e8af4 into 30b35cd - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging bf99c0c into 7f29489 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 38646da into 850f6d9 - view on LGTM.com new alerts:
|
…he membership identifier Initial refactor: removal of NetMember, MemberAttributes and other classes that subordinated GMS identifiers. Repurposing GMSMember as a data packet to hold information required in a membership identifer.
these identifiers morph after the client's membership identifier has been formed so the member ID needs to be updated before serializing it
bschuchardt
force-pushed
the
feature/GEODE-7358
branch
from
ee12299
to
2556313
Compare
|
This pull request introduces 1 alert when merging db37e1d into d30e2e8 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ca001e1 into 0015532 - view on LGTM.com new alerts:
|
upthewaterspout
changed the title
upthewaterspout
previously approved these changes
Oct 30, 2019
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
Show resolved
Hide resolved
upthewaterspout
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.