GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geode v1.11 inadvertently changed the form of its saved membership view by using a FileOutputStream to write it to disk instead of using an ObjectOutputStream. The latter writes additional information during serialization. Note: there is already a test for this change that will start running when v1.12 is created and v1.11 is added as a geode-old-version in settings.gradle.
bschuchardt
requested review from
Bill,
upthewaterspout,
echobravopapa and
mhansonp
upthewaterspout
approved these changes
Jan 6, 2020
...e/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
Outdated
Show resolved
Hide resolved
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Jan 14, 2020
…ns (apache#4564) * GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions Geode v1.11 inadvertently changed the form of its saved membership view by using a FileOutputStream to write it to disk instead of using an ObjectOutputStream. The latter writes additional information during serialization. Note: there is already a test for this change that will start running when v1.12 is created and v1.11 is added as a geode-old-version in settings.gradle. * corrected serialization in integration test * flipping equals() check to avoid possible NPE
mhansonp
added a commit
to mhansonp/geode
that referenced
this pull request
Jan 17, 2020
…d-versions (apache#4564)" This reverts commit 0b23275
davebarnes97
pushed a commit
to davebarnes97/geode
that referenced
this pull request
Jan 22, 2020
…ns (apache#4564) * GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions Geode v1.11 inadvertently changed the form of its saved membership view by using a FileOutputStream to write it to disk instead of using an ObjectOutputStream. The latter writes additional information during serialization. Note: there is already a test for this change that will start running when v1.12 is created and v1.11 is added as a geode-old-version in settings.gradle. * corrected serialization in integration test * flipping equals() check to avoid possible NPE
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 12, 2020
…ns (apache#4564) * GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions Geode v1.11 inadvertently changed the form of its saved membership view by using a FileOutputStream to write it to disk instead of using an ObjectOutputStream. The latter writes additional information during serialization. Note: there is already a test for this change that will start running when v1.12 is created and v1.11 is added as a geode-old-version in settings.gradle. * corrected serialization in integration test * flipping equals() check to avoid possible NPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geode v1.11 inadvertently changed the form of its saved membership view
by using a FileOutputStream to write it to disk instead of using
an ObjectOutputStream. The latter writes additional information during
serialization.
Note: there is already a test for this change that will start running
when v1.12 is created and v1.11 is added as a geode-old-version in
settings.gradle.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.