Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions #4564

Merged
merged 3 commits into from Jan 7, 2020
Merged

GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions #4564

merged 3 commits into from Jan 7, 2020

Commits on Jan 6, 2020

  1. GEODE-7649 upgrade tests fail when v1.11 is added to geode-old-versions 

    Geode v1.11 inadvertently changed the form of its saved membership view
by using a FileOutputStream to write it to disk instead of using
an ObjectOutputStream.  The latter writes additional information during
serialization.

Note: there is already a test for this change that will start running
when v1.12 is created and v1.11 is added as a geode-old-version in
settings.gradle.
    @bschuchardt
    bschuchardt committed Jan 6, 2020
    Copy the full SHA
    c11c856 View commit details
    Browse the repository at this point in the history

  2. corrected serialization in integration test

    @bschuchardt
    bschuchardt committed Jan 6, 2020
    Copy the full SHA
    0cc482a View commit details
    Browse the repository at this point in the history

  3. flipping equals() check to avoid possible NPE

    @bschuchardt
    bschuchardt committed Jan 6, 2020
    Copy the full SHA
    9df4ffe View commit details
    Browse the repository at this point in the history