-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-7727: modify sender thread to detect release of connection #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanac
force-pushed
the
feature/GEODE-7727
branch
from
February 11, 2020 10:10
f8555b6
to
d604444
Compare
mivanac
force-pushed
the
feature/GEODE-7727
branch
from
February 13, 2020 15:11
a17c827
to
7e9c7d4
Compare
bschuchardt
requested changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of minor questions and am concerned about the removal of the (!isHandshakeReader) test.
geode-core/src/distributedTest/java/org/apache/geode/internal/tcp/TCPConduitDUnitTest.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
Outdated
Show resolved
Hide resolved
mivanac
force-pushed
the
feature/GEODE-7727
branch
from
February 13, 2020 18:36
34c086d
to
072377d
Compare
bschuchardt
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mario
DonalEvans
added a commit
to DonalEvans/geode
that referenced
this pull request
Feb 22, 2020
…ion (apache#4629)" This reverts commit 1a0d976.
6 tasks
ghost
pushed a commit
to prettyClouds/geode
that referenced
this pull request
Feb 26, 2020
…ion (apache#4629)" (apache#4726) This reverts commit 1a0d976.
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 12, 2020
…che#4629) * GEODE-7727: modify sender thread to detect relese of connection * GEODE-7727: Update solution only for shared connections * GEODE-7727: added test * GEODE-7727: update ater comments * GEODE-7727: update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[*] Has your PR been rebased against the latest commit within the target branch (typically
develop
)?[*] Is your initial contribution a single, squashed commit?
[*] Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.