Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7851: use the latest version of nimbus-jose-jwt.jar #4851

Merged
merged 5 commits into from
Mar 30, 2020

Conversation

jinmeiliao
Copy link
Member

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@jmelchio
Copy link
Contributor

I'm wondering if we may have to wait until the dependencies are updated in the spring libraries that use this jar.

Copy link
Contributor

@jmelchio jmelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinmeiliao
Copy link
Member Author

I'm wondering if we may have to wait until the dependencies are updated in the spring libraries that use this jar.

we don't have to. Gradle will substitute the spring dependency with the latest.

@jinmeiliao jinmeiliao merged commit 4984ed9 into apache:develop Mar 30, 2020
@jinmeiliao jinmeiliao deleted the upgrade branch March 30, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants