GEODE-7938: added keys query param to GET, PUT, and DELETE /{region} endpoints #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to test that region name encoding is correct need to verify the Content-Location is correct
…was ordered * the code that tests for missing keys now uses the getAll result instead of sending multiple messsages and having a race in which key is deleted after the old check but before getAll * the Content-Location is now set correctly when doing a get with encoded keys * added more tests for better coverage of the PdxBasedCrudController.
dschneider-pivotal
requested review from
jake-at-work,
demery-pivotal,
jinmeiliao and
jmelchio
dschneider-pivotal
changed the title
demery-pivotal
approved these changes
Apr 7, 2020
...rationTest/java/org/apache/geode/rest/internal/web/controllers/RestAccessControllerTest.java
Outdated
Show resolved
Hide resolved
...rationTest/java/org/apache/geode/rest/internal/web/controllers/RestAccessControllerTest.java
Outdated
Show resolved
Hide resolved
...rationTest/java/org/apache/geode/rest/internal/web/controllers/RestAccessControllerTest.java
Show resolved
Hide resolved
|
This pull request introduces 2 alerts when merging fdd541b into 1b1ad6b - view on LGTM.com new alerts:
|
jinmeiliao
approved these changes
Apr 7, 2020
This allows users to create entries that have an encodedKey.
jmelchio
added a commit
to jmelchio/geode
that referenced
this pull request
Apr 8, 2020
…region} endpoints (apache#4901)" This reverts commit 6263f1f.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix did not handle initial slashes (see GEODE-7938).
So now we have a new queryParam "?keys=" that can be used in place of the old {keys} pathVar.
The new queryParam expects its keys to be encoded with UTF-8.
The previous fixes "/**" has been removed since it did harm to swagger.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.