GEODE-8230: run benchmarks in parallel with other CI jobs #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line jobs UnitTest and ApiChecker
onichols-pivotal
requested review from
dickcav,
metatype,
nabarunnag,
rhoughton-pivot and
jake-at-work
dickcav
approved these changes
Jun 6, 2020
dickcav
approved these changes
Jun 6, 2020
mkevo
approved these changes
Jun 6, 2020
onichols-pivotal
deleted the
GEODE-8230-run-benchmarks-in-parallel-with-other-CI-jobs
branch
onichols-pivotal
added a commit
that referenced
this pull request
Jun 9, 2020
* run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab (cherry picked from commit f65ea45)
onichols-pivotal
added a commit
that referenced
this pull request
Jun 9, 2020
* run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic already-required-in-PR-pipeline jobs UnitTest and ApiChecker * add Benchmarks tab (cherry picked from commit f65ea45)
bschuchardt
pushed a commit
to bschuchardt/geode
that referenced
this pull request
Jul 13, 2020
* run benchmarks in parallel with other CI jobs * eliminate JDK11 flavors for deterministic job UnitTest * add Benchmarks tab (cherry picked from commit f65ea45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, we ran Build, then all Test jobs in parallel (which takes ~5 hours), then all Benchmark jobs (which takes ~5 hours).
Presumably the benchmarks were run after all tests, on the premise that benchmarks are meaningless if the code is not correct. However, required PR checks now prevent incorrect code from getting into develop in the first place, and the remaining occasional failures are flaky, so it's rather arbitrary to gate benchmarks on a lottery.
However, faster feedback has clear benefits, hence this PR to cut our CI pipeline from 10 hours to 5 hours.
Also eliminates redundant jobs (ApiCheck and UnitTest are deterministic and already have required JDK11 flavors in the PR pipeline, so JDK8 flavor only is more than sufficient in the develop pipeline)
Also decreases benchmarks max_in_flight from 3 to 2, since now that we have support branches, we don't want to max our quota just from develop. Some sort of global "pool" resource might be a more elegant way to manage this resource quota across pipelines.