Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-6150: added test (Allow use of client/server max-threads with SSL) #5270

Closed
wants to merge 10 commits into from

Conversation

mivanac
Copy link
Contributor

@mivanac mivanac commented Jun 17, 2020

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [*] Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • [*] Is your initial contribution a single, squashed commit?

  • [*] Does gradlew build run cleanly?

  • [*] Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2020

This pull request introduces 8 alerts and fixes 2 when merging 5ee88eb into d1e857d - view on LGTM.com

new alerts:

  • 3 for Potential output resource leak
  • 3 for Dereferenced variable may be null
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request introduces 9 alerts and fixes 2 when merging 9a7df46 into 9939cc0 - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null
  • 3 for Potential output resource leak
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 9 alerts and fixes 2 when merging 43052f3 into ca5d961 - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null
  • 3 for Potential output resource leak
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 9 alerts and fixes 2 when merging 9026687 into 210dc4f - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null
  • 3 for Potential output resource leak
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

1 similar comment
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 9 alerts and fixes 2 when merging 9026687 into 210dc4f - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null
  • 3 for Potential output resource leak
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Jun 26, 2020

This pull request introduces 9 alerts and fixes 2 when merging f5bd688 into c9ed7d7 - view on LGTM.com

new alerts:

  • 4 for Dereferenced variable may be null
  • 3 for Potential output resource leak
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@onichols-pivotal
Copy link
Contributor

this PR appears to have been abandoned

@lgtm-com
Copy link

lgtm-com bot commented Oct 23, 2020

This pull request introduces 10 alerts and fixes 2 when merging 0d64a52 into 0fdfc1a - view on LGTM.com

new alerts:

  • 4 for Potential output resource leak
  • 4 for Dereferenced variable may be null
  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2020

This pull request introduces 2 alerts and fixes 2 when merging 45ea842 into 0fdfc1a - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2020

This pull request fixes 2 alerts when merging 63821bf into 0fdfc1a - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@kohlmu-pivotal
Copy link
Contributor

@mivanac could you please have a look at this PR again.
Please either close or update for review.

@onichols-pivotal onichols-pivotal marked this pull request as draft October 26, 2020 03:43
@mivanac mivanac marked this pull request as ready for review October 30, 2020 15:01
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 2 alerts when merging f141bc0 into a00f18d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@mivanac
Copy link
Contributor Author

mivanac commented Oct 30, 2020

This is PoC. Now I will start working on systematization of solution. Comments are welcome.

@kohlmu-pivotal
Copy link
Contributor

@mivanac If this is PoC, would you please convert this to a "draft" PR, that way we can exclude it from explicitly trying to review the work for merger.

@mivanac mivanac marked this pull request as draft October 30, 2020 19:36
@bschuchardt bschuchardt changed the title GEODE-6150: added test GEODE-6150: added test (Allow use of client/server max-threads with SSL) Jan 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2021

This pull request fixes 2 alerts when merging 6339cae into ea37a2d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@mivanac mivanac closed this Feb 27, 2021
@mivanac
Copy link
Contributor Author

mivanac commented Feb 27, 2021

New PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants