GEODE-8394: Rewind the message Part on command failure #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agingade
requested review from
dschneider-pivotal,
boglesby,
gesterzhou,
kirklund and
nabarunnag
dschneider-pivotal
approved these changes
Aug 4, 2020
jchen21
reviewed
Aug 5, 2020
| import org.apache.geode.test.junit.categories.ClientServerTest; | ||
|
|
||
| @Category({ClientServerTest.class}) | ||
| public class ClientServerCacheOperationDUnitTest implements Serializable { |
There was a problem hiding this comment.
The DUnitTest passes even without the fix in Part.java. I expect the DUnitTest will fail and reproduce GEODE-8394 without the fixes in Part.java. Maybe I am missing something.
There was a problem hiding this comment.
It was the test used to reproduce the original issue and test the fix. If you can see it has dependency on environment and shows flaky-ness...With adjusting the time; it is more of becoming a test for large object.
agingade
pushed a commit
that referenced
this pull request
Aug 8, 2020
GEODE-8394: Rewind the message Part on failure Co-authored-by: anilkumar gingade <anil@anilg.local> (cherry picked from commit 83d1e28)
agingade
pushed a commit
that referenced
this pull request
Aug 8, 2020
GEODE-8394: Rewind the message Part on failure Co-authored-by: anilkumar gingade <anil@anilg.local> (cherry picked from commit 83d1e28)
agingade
pushed a commit
that referenced
this pull request
Aug 8, 2020
GEODE-8394: Rewind the message Part on failure Co-authored-by: anilkumar gingade <anil@anilg.local> (cherry picked from commit 83d1e28)
kohlmu-pivotal
pushed a commit
to kohlmu-pivotal/geode
that referenced
this pull request
Aug 10, 2020
GEODE-8394: Rewind the message Part on failure Co-authored-by: anilkumar gingade <anil@anilg.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rewinds the message part on command failure. Without this during retry on failure, the message (Part) is sent from the place where it was previously failed, instead of starting from the beginning, causing it to transmit partial data.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
[Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[Y] Has your PR been rebased against the latest commit within the target branch (typically
develop)?[Y] Is your initial contribution a single, squashed commit?
[Y] Does
gradlew buildrun cleanly?[Y] Have you written or updated unit tests to verify your changes?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.