-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-8782: Add getPrincipal method to FunctionContext interface #5897
GEODE-8782: Add getPrincipal method to FunctionContext interface #5897
Conversation
allCommands.put(Version.GEODE_1_13_0, geode18Commands); | ||
allCommands.put(Version.GEODE_1_13_1, geode18Commands); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need another PR to add GEODE_1_12_1 and GEODE_1_13_1 to develop as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
If memory serves, we had similar port conflict errors on develop after 1.13.1 was released, which was solved by 9d139b5. I've cherry-picked that fix to your PR. |
…pache#5502) * add 1.13.0 to old versions and set as Benchmarks baseline on develop * leave HTTP service off in WAN and Lucene rolling upgrade tests to avoid port conflict Co-authored-by: Bill Burcham <bill.burcham@gmail.com> (cherry picked from commit 9d139b5)
…pivotal/geode into GEODE-8782-backported-1-13
looks good! |
when a SecurityManager is enabled.
version for GEODE_1_12_1.
(cherry picked from commit a42f89a)
(cherry picked from commit 0ab6771)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.