GEODE-9070: Fix flaky behavior in ClientServerSessionCacheDUnit tests #6390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabbey37
requested review from
BenjaminPerryRoss and
jdeppe-pivotal
as code owners
|
Feel free to suggest or add other log statements that might be helpful in debugging if the failure happens again. |
sabbey37
commented
Apr 29, 2021
| @@ -97,6 +100,9 @@ protected Cache verifyCacheExists() { | |||
| } | |||
|
|
|||
| if (cache == null) { | |||
| if (logger.isDebugEnabled()) { | |||
| logger.debug("Creating a new cache in BootstrappingFunction"); | |||
There was a problem hiding this comment.
Is this the proper log level?
There was a problem hiding this comment.
I'd suggest to setting it to info so that it's always visible.
jdeppe-pivotal
approved these changes
Apr 30, 2021
|
Closed in favor of: #6567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until cache server is running before attempting to start the client or validate the server.