GEODE-9155: Change frequency of passive expiration #6419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the interval in the PassiveExpirationManager from 1 second to 3 minutes. this significantly reduces the CPU load of passive expiration. this change requires that one redis test must be commented out in the patch file.
nonbinaryprogrammer
requested review from
jdeppe-pivotal,
ringles and
sabbey37
as code owners
…stats, which the test is sensitive to
sabbey37
approved these changes
May 3, 2021
nonbinaryprogrammer
added a commit
that referenced
this pull request
May 4, 2021
This reverts commit 113aa7d.
nabarunnag
pushed a commit
to nabarunnag/geode
that referenced
this pull request
May 4, 2021
* GEODE-9155: Change frequency of passive expiration change the interval in the PassiveExpirationManager from 1 second to 3 minutes. this significantly reduces the CPU load of passive expiration. this change requires that one redis test must be commented out in the patch file. * use the keys command instead of hkeys. hkeys increments the hit/miss stats, which the test is sensitive to (cherry picked from commit 113aa7d)
nonbinaryprogrammer
added a commit
that referenced
this pull request
May 13, 2021
GEODE-9155: Change frequency of passive expiration change the interval in the PassiveExpirationManager from 1 second to 3 minutes. this significantly reduces the CPU load of passive expiration. this change requires that one redis test must be commented out in the patch file. (cherry picked from commit 113aa7d) Co-authored-by: Hale Bales <hbales@vmware.com>
luissson
added a commit
to luissson/geode
that referenced
this pull request
May 21, 2021
…) (apache#6432)" This reverts commit fb00b27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the interval in the PassiveExpirationManager from 1 second to 3
minutes. this significantly reduces the CPU load of passive expiration.
this change requires that one redis test must be commented out in the
patch file.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.