Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-9155: Change frequency of passive expiration (#6419) #6432

Merged

Conversation

nabarunnag
Copy link
Contributor

  • GEODE-9155: Change frequency of passive expiration

change the interval in the PassiveExpirationManager from 1 second to 3
minutes. this significantly reduces the CPU load of passive expiration.

this change requires that one redis test must be commented out in the
patch file.

  • use the keys command instead of hkeys. hkeys increments the hit/miss stats, which the test is sensitive to

(cherry picked from commit 113aa7d)

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

* GEODE-9155: Change frequency of passive expiration

change the interval in the PassiveExpirationManager from 1 second to 3
minutes. this significantly reduces the CPU load of passive expiration.

this change requires that one redis test must be commented out in the
patch file.

* use the keys command instead of hkeys. hkeys increments the hit/miss stats, which the test is sensitive to

(cherry picked from commit 113aa7d)
@jdeppe-pivotal jdeppe-pivotal added backport PR related to backporting changes redis Issues related to the geode-for-redis module labels May 5, 2021
@nonbinaryprogrammer nonbinaryprogrammer merged commit fb00b27 into apache:support/1.14 May 13, 2021
luissson added a commit to luissson/geode that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR related to backporting changes redis Issues related to the geode-for-redis module
Projects
None yet
3 participants