GEODE-9443: Increase pid_max in CI images #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain Geode tests create a lot of threads. When these tests run in parallel with many other tests (as they do in CI), the whole set of concurrently running tests can overwhelm the Linux kernel's ability to assign PIDs to new threads. When this happens, test processes, Gradle processes, and other processes can become unable to create new threads. The relevant system parameter is `kernel.pid_max`. In our CI images, `pid_max` is 98,304. This commit raises CI images' `pid_max` to 983040 (10x the default value). A build can run 24 concurrent instances of even our most thread-heavy tests without exceeding this threshold. Co-authored-by: Dale Emery <demery@vmware.com>
demery-pivotal
requested review from
dickcav,
onichols-pivotal,
rhoughton-pivot and
smgoller
as code owners
onichols-pivotal
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Geode tests create a lot of threads. When these tests run in
parallel with many other tests (as they do in CI), the whole set of
concurrently running tests can overwhelm the Linux kernel's ability to
assign PIDs to new threads. When this happens, test processes, Gradle
processes, and other processes can become unable to create new threads.
The relevant system parameter is
kernel.pid_max. In our CI images,pid_maxis 98,304.This commit raises CI images'
pid_maxto 983040 (10x the defaultvalue). A build can run 24 concurrent instances of even our most
thread-heavy tests without exceeding this threshold.
Co-authored-by: Dale Emery demery@vmware.com