Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial: back port re-auth to 1.12 support branch #7476

Closed
wants to merge 7 commits into from

Conversation

jinmeiliao
Copy link
Member

No description provided.

@jinmeiliao jinmeiliao force-pushed the 1.12.reAuth branch 3 times, most recently from bd46447 to 51bb031 Compare March 23, 2022 02:09
@jinmeiliao jinmeiliao marked this pull request as ready for review March 23, 2022 16:36
@jinmeiliao jinmeiliao marked this pull request as draft March 23, 2022 16:37
@apache apache deleted a comment from lgtm-com bot Mar 23, 2022
@apache apache deleted a comment from lgtm-com bot Mar 23, 2022
@apache apache deleted a comment from lgtm-com bot Mar 23, 2022
@apache apache deleted a comment from lgtm-com bot Mar 23, 2022
@apache apache deleted a comment from lgtm-com bot Mar 23, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2022

This pull request fixes 1 alert when merging 74cd411 into 1d45268 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2022

This pull request fixes 1 alert when merging bce6724 into 1d45268 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2022

This pull request fixes 1 alert when merging 40997d8 into 1d45268 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2022

This pull request fixes 1 alert when merging b48926e into 1d45268 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

kirklund and others added 7 commits March 29, 2022 16:01
Improve testability of CacheClientProxy
* Extract inner classes
* Introduce CacheClientProxyFactory with support for property injection

(cherry picked from commit a2ac820)
Revert fluent style usage of ClientRegionFactory in:
* DeltaPropagationDUnitTest
* PutAllClientServerDistributedTest

(cherry picked from commit cceaa66)
… (squashed)

GEODE-10042: do not make ClientUserAuths null when we are not unregister client yet. (apache#7357)

* make cleanUserAuths synchronized to avoid NPE
* This also pass down client termination reason when we clean up client threads.
* since we introduced a lock object for clientUserAuths, revert some  old code to not to catch NPE but use the lock
* synchronize all clientUserAuths updates.

GEODE-9985: add region redundancy to avoid data loss. (apache#7308)

GEODE-9900: ensure AuthenticationExpiredException handling (apache#7207)

* GEODE-9900: ensure AuthenticationExpiredException handling

- in CloseCQ command
- Add unit tests to confirm proper message is sent

GEODE-9875: client operation should not send in invalid userId. (apache#7173)

GEODE-9867: do not process the message if the connection is terminated (apache#7158)

GEODE-9803: Fix the flaky "Failed To find authenticated user" problem (apache#7149)

* GEODE-9803: Fix the flaky "Failed To find authenticated user" problem

* Only to update subject on the ClientCacheProxy if it's waiting for re-auth
* logout the subject in one place when we close the dispatcher
* reset the timer when we stopped waiting

GEODE-9820: stopCQ should handle general exception same way as ExecuteCQ61 (apache#7122)

GEODE-9803: turning on security debug log in the test and add more debug logging (apache#7117)

GEODE-9746: do not logout old subjects immediately when we get a new subject for the same uniqueId (apache#7063)

* add more logging for future debugging
* minor bug fix in CacheClientProxy

GEODE-9792: synchronize multi-user authentication on different threads (apache#7088)

GEODE-9792: avoid sending in multiple authentication request on the same connection by different threads. (apache#7067)

GEODE-9723: test transactions with auth expiration (apache#7012)

Add tests to confirm that client transactions are not disrupted when authentication expires and automatic re-authentication takes place.

    complete transaction with commit
    transaction rollback
    suspended and resumed transaction with commit
    failed re-authentication with commit and rollback on partial transaction
    add test to include PARTITION region behavior

GEODE-9674: For durable client, when client reconnects, server should retrieve the message from the queue, not continue to try to deliver the last un-delivered message.

GEODE-9749: ignore the test case that shows GEODE-9704. (apache#7015)

GEODE-9534, GEODE-9540: add more tests for peer communication and bulk operations (apache#6985)

* add more tests for durable clients

GEODE-9674: fix durable client message loss issue in tests. (apache#6947)

* for caching_proxy region, count the events received instread of the region size
* do not try to dispatch residual messages when exception occurred.
* add durable client flag when register interest

GEODE-9534: get rid of some test warnings (apache#6945)

GEODE-9663: refactor authenticateIfRequired (apache#6948)

GEODE-9663: throw and handle AuthenticationExpiredException at login time (apache#6927)

* GEODE-9663: throw and handle AuthenticationExpiredException at login time

GEODE-9658: refactor test AuthInit to not use static field for credentials. (apache#6922)

GEODE-9570: make sure re-authentication works with registered interests (apache#6885)

GEODE-9459: testing clients with WAN connected cluster (apache#6901)

GEODE-9457: re-authentication in event dispatcher (apache#6835)

* authorize the message before dispatching the message to the client
* add a new message type to be sent to the client for re-authentiate
* message dispatcher will wait for a certain time for client to reauthenticate before terminating the client
* when re-authenticate, the new subject will re-use the original uniqueId. Credentials will be sent to the user along with the old uniqueId if exists.
* old subject will be cleaned out when new subject re-authenticate back.
* re-auth multi-user mode in event dispatching is not supported (yet).

GEODE-9458: Enhance function execution testing auth expiry (apache#6865)

* GEODE-9458: Enhance function execution testing auth expiry

GEODE-9521: add more multi-server test scenario (apache#6860)

* remove the static methods in ExpirableSecurityManager

GEODE-9586: modify 1.15.0's client server protocol version (apache#6846)

GEODE-9458: function execution with expiring authentication (apache#6789)

* GEODE-9456, GEODE-9452: Authentication Expiration (apache#6721)

* Add tests and throw AuthenticationExpiredException
Co-authored-by: Joris Melchior <joris.melchior@gmail.com>

* GEODE-9460: Add testing for mutli-user scenarios (apache#6755)

Co-Authored-By Jinmei Liao <jiliao@vmware.com>

* review update

* revert accidental change

* GEODE-9458: function execution with expiring authentication

* Changes based on review

* Changes based on review, parameterization

Co-authored-by: Jinmei Liao <jiliao@pivotal.io>

GEODE-9451: On demand authentication expiration and re-authentication (apache#6787)

* GEODE-9456, GEODE-9452: Authentication Expiration (apache#6721)
* Add tests and throw AuthenticationExpiredException
* GEODE-9460: Add testing for mutli-user scenarios (apache#6755)

Co-authored-by: Joris Melchior <joris.melchior@gmail.com>
* move test to cq module
* add old client support service to cq module and core upgrade test
* have feature-start-version to be 1.12.10
* no "during" method
…Exception (part 2) (apache#7155)

* fix this in the login method as well
@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2022

This pull request fixes 2 alerts when merging f1be330 into 36d9260 - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@jinmeiliao jinmeiliao closed this Apr 29, 2022
@jinmeiliao jinmeiliao deleted the 1.12.reAuth branch April 29, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants