Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with geode home determination #7550

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion geode-assembly/src/main/dist/bin/gfsh.bat
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ REM

setlocal enableextensions
set scriptdir=%~dp0
set gf=%scriptdir:\bin\=%
REM Remove last 4 chars corresponding to bin\
set gf=%scriptdir:~0,-4%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add a short comment so anyone else, looking at this in the future, knows why 4 in particular. Maybe:

REM Remove last 4 chars corresponding to bin\

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

REM echo %gf%
REM echo %scriptdir%
if exist "%gf%\lib\geode-dependencies.jar" goto gfok
Expand Down