Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with geode home determination #7550

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thesteve0
Copy link

If you place the product_dir in a path with "bin" in, the old method would ruin the path. For example
C:\Users\steve\bin\apache-geode-1.14.4\bin\

would become
C:\Users\steveapache-geode-1.14.4

This implementation cuts off the last 4 letters of the bin directory to get to the installation location.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

If you place the product_dir in a path with "bin" in, the old method would ruin the path. For example 
`C:\Users\steve\bin\apache-geode-1.14.4\bin\`

would become
`C:\Users\steveapache-geode-1.14.4`

This implementation cuts off the last 4 letters of the bin directory to get to the installation location.
@@ -27,7 +27,7 @@ REM

setlocal enableextensions
set scriptdir=%~dp0
set gf=%scriptdir:\bin\=%
set gf=%scriptdir:~0,-4%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add a short comment so anyone else, looking at this in the future, knows why 4 in particular. Maybe:

REM Remove last 4 chars corresponding to bin\

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@thesteve0
Copy link
Author

Changes made

@thesteve0
Copy link
Author

That concourse build failure does not look related to my change - how do I clear it?

@kirklund
Copy link
Contributor

That concourse build failure does not look related to my change - how do I clear it?

@thesteve0 You can either use:

git commit --allow-empty-message -m "Trigger precheckin"

or if you have access to tanzu projects, you can trigger just precheckin for unit-test using:

https://cio.hdb.gemfire-ci.info/pr-tool

Copy link
Contributor

@mhansonp mhansonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you investigated why the unit tests are failing?

@thesteve0
Copy link
Author

Have you investigated why the unit tests are failing?

There are 37 failures - all of them Java exceptions some related to Mockito.

I changed 1 line in a windows bat file.

This seems to be something wrong with the test harness since I did not touch Java code

@onichols-pivotal onichols-pivotal dismissed mhansonp’s stale review May 21, 2022 01:23

passing unit tests are already a prerequisite to merge.

re-trigger CI since new checks have been added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants