-
Notifications
You must be signed in to change notification settings - Fork 744
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GOBBLIN-1575] use reference count in helix manager, so that connect/…
…disconnect are called once and at the right time (#3427) * make a copy of helix manager, so that each job can keep using it without worrying about disconnect * address review comments * address review comments * use reference count to connect/disconnect only once * address review comments
- Loading branch information
1 parent
374fd6f
commit 89497c6
Showing
8 changed files
with
116 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixManagerFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.gobblin.cluster; | ||
|
|
||
| import org.apache.helix.InstanceType; | ||
|
|
||
|
|
||
| public class GobblinHelixManagerFactory { | ||
|
|
||
| public static GobblinReferenceCountingZkHelixManager getZKHelixManager(String clusterName, String instanceName, | ||
| InstanceType type, String zkAddr) { | ||
| return new GobblinReferenceCountingZkHelixManager(clusterName, instanceName, type, zkAddr); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
...ster/src/main/java/org/apache/gobblin/cluster/GobblinReferenceCountingZkHelixManager.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.gobblin.cluster; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| import org.apache.helix.InstanceType; | ||
| import org.apache.helix.manager.zk.ZKHelixManager; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
|
|
||
| /** | ||
| * A {@link ZKHelixManager} which keeps a reference count of users. | ||
| * Every user should call connect and disconnect to increase and decrease the count. | ||
| * Calls to connect and disconnect to the underlying ZKHelixManager are made only for the first and last usage respectively. | ||
| */ | ||
| @Slf4j | ||
| public class GobblinReferenceCountingZkHelixManager extends ZKHelixManager { | ||
| private final AtomicInteger usageCount = new AtomicInteger(0); | ||
|
|
||
| public GobblinReferenceCountingZkHelixManager(String clusterName, String instanceName, InstanceType instanceType, String zkAddress) { | ||
| super(clusterName, instanceName, instanceType, zkAddress); | ||
| } | ||
|
|
||
| @Override | ||
| public void connect() throws Exception { | ||
| if (usageCount.incrementAndGet() == 1) { | ||
| super.connect(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void disconnect() { | ||
| if (usageCount.decrementAndGet() <= 0) { | ||
| super.disconnect(); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters