Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-469 gora-core build problem is solved under jdk1.8 #79

Merged
merged 2 commits into from
Aug 28, 2016

Conversation

cguzel
Copy link
Member

@cguzel cguzel commented Aug 27, 2016

No description provided.

@cguzel
Copy link
Member Author

cguzel commented Aug 27, 2016

There is no problem in existing code. Only the try catch block is incorrect. JDK 1.7 and JDK 1.8 behave differently for this case.

@cguzel cguzel changed the title GORA-469 gora build problem is solved under jdk1.8 GORA-469 gora-core build problem is solved under jdk1.8 Aug 27, 2016
@lewismc
Copy link
Member

lewismc commented Aug 28, 2016

When I apply the patch I get the following

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:11 min
[INFO] Finished at: 2016-08-27T18:04:16-07:00
[INFO] Final Memory: 42M/427M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (attach-javadocs) on project gora-cassandra: MavenReportException: Error while creating archive:
[ERROR] Exit code: 1 - /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraQuery.java:64: warning: no @param for familyMap
[ERROR] public void setFamilyMap(Map<String, List<String>> familyMap) {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraQuery.java:71: warning: no @return
[ERROR] public Map<String, List<String>> getFamilyMap() {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraQuery.java:99: error: invalid use of @return
[ERROR] * @return set a {@link org.apache.gora.cassandra.query.CassandraQuery}
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraQuery.java:101: warning: no @param for query
[ERROR] public void setQuery(Query<K, T> query) {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraResult.java:184: warning: no description for @param
[ERROR] * @param cassandraResultSet
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraRow.java:47: warning: no description for @param
[ERROR] * @param pCassandraColumnName
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:99: warning: no @param for keyClass
[ERROR] public void initialize(Class<K> keyClass, Class<T> persistentClass)
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:99: warning: no @param for persistentClass
[ERROR] public void initialize(Class<K> keyClass, Class<T> persistentClass)
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:99: warning: no @throws for java.lang.Exception
[ERROR] public void initialize(Class<K> keyClass, Class<T> persistentClass)
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:118: warning: no description for @throws
[ERROR] * @throws Exception
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:160: warning: no @return
[ERROR] public boolean keyspaceExists() {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:301: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:302: warning: no description for @param
[ERROR] * @param familyName
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:303: warning: no description for @param
[ERROR] * @param columnName
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:313: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:390: warning: no description for @param
[ERROR] * @param key
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:391: warning: no description for @param
[ERROR] * @param fieldName
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:392: warning: no description for @param
[ERROR] * @param columnName
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:584: warning: no description for @return
[ERROR] * @return
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:593: warning: no description for @param
[ERROR] * @param query
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:613: warning: no description for @param
[ERROR] * @param family
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:73: warning: no description for @param
[ERROR] * @param <K>
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java:74: warning: no description for @param
[ERROR] * @param <T>
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraMapping.java:114: warning: no description for @return
[ERROR] * @return
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraMapping.java:144: warning: no @param for keyspace
[ERROR] public CassandraMapping(Element keyspace, Element mapping) {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraMapping.java:144: warning: no @param for mapping
[ERROR] public CassandraMapping(Element keyspace, Element mapping) {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraMappingManager.java:94: warning: no description for @throws
[ERROR] * @throws JDOMException
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraMappingManager.java:95: warning: no description for @throws
[ERROR] * @throws IOException
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java:139: warning: no description for @param
[ERROR] * @param keyClass
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java:140: warning: no description for @param
[ERROR] * @param persistent
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java:141: warning: no description for @param
[ERROR] * @param properties
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java:130: warning: no @throws for java.lang.Exception
[ERROR] public CassandraStore() throws Exception {
[ERROR] ^
[ERROR] /usr/local/gora-dev/gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java:415: warning - Tag @link: can't find getFieldValue(Schema, Type, Object) in org.apache.gora.cassandra.store.CassandraStore
[ERROR]
[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/usr/local/gora-dev/gora-cassandra/target/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :gora-cassandra

@cguzel
Copy link
Member Author

cguzel commented Aug 28, 2016

The previous error is releated gora-core. I fixed it. This last error log is releated gora-cassandra. This is different problem.

If I run "mvn clean install", it fails. If I run as "mvn clean install -rf :gora-cassandra", it build successfully. If I build only gora-cassandra, it build successfully too. I don't understood what is problem.

@lewismc
Copy link
Member

lewismc commented Aug 28, 2016

The issue is with the Javadoc. By default, when building the JDK1.8 required Javadoc specification compliance. I will merge this PR ans we can get to work on the Javadoc for gora-cassandra.

@asfgit asfgit merged commit 498c783 into apache:master Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants