-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows build instructions to how-to-build.md #3578
Conversation
Can you create a fork of Gravitino and use your own repo to create the PR? |
``` | ||
|
||
3. Save and quit in vim using `:wq`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add
- Run
source ~/.bashrc
to which updates the .bashrc file in your current shell session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks Tao!
|
||
**On Ubuntu (WSL):** | ||
|
||
Refer to chatGPT for specific instructions. Here are the steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these steps been validated locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I made it to install docker on WSL.
ok, I will close current pr and create another one. Thanks Qian! |
What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
This pull request adds instructions for building Gravitino on Windows using the Windows Subsystem for Linux (WSL). The new section provides a detailed step-by-step guide to setting up the necessary environment and dependencies on Windows to successfully build and run Gravitino. Additionally, it includes specific instructions provided by minghuang and docs written by Junshen Tao, which have been tested and proven effective for building the project.
Why are the changes needed?
These changes are needed to provide Windows users with clear and concise instructions on how to build Gravitino using WSL. This expands the accessibility of the project to a wider audience who may be using Windows as their primary development environment. It addresses the need for comprehensive documentation that covers all major operating systems, including Windows.
Fixes: # (No specific issue)
Does this PR introduce any user-facing change?
No user-facing APIs or properties were changed. The addition is purely documentation, aimed at helping developers set up their environment on Windows using WSL.
How was this patch tested?
The documentation changes were reviewed for accuracy and clarity. The steps outlined were followed to ensure they work as described, using an environment set up with Windows 11 and Ubuntu 22.04 on WSL. The specific instructions provided by minghuang were used to successfully build the project, confirming their effectiveness.