[#1908] Fix: In HadoopCatalogOperations.java field entity is not used #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poojatalele |
@yuqi1129 |
|
You ned to run |
Pls check now once |
Any update? |
jerryshao
reviewed
Aug 19, 2024
| Entity.EntityType.SCHEMA, | ||
| schemaEntity -> updateSchemaEntity(ident, schemaEntity, changes)); | ||
|
|
||
| SchemaEntity entity = store.get(ident, Entity.EntityType.SCHEMA, SchemaEntity.class); |
There was a problem hiding this comment.
I'm not sure why do you add this line of code here, can you explain more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed the unused entity variable in the alterSchema method of HadoopCatalogOperations.java. The refactored code now directly updates the schema and retrieves the updated schema entity for returning.
Why are the changes needed?
The entity variable was assigned but never used, which was flagged as a possible bug.
Removing this unused variable makes the code cleaner and easier to maintain.
Fix: #1908
Does this PR introduce any user-facing change?
No, this PR does not introduce any user-facing changes.
How was this patch tested?