Skip to content

Commit

Permalink
Bump ASM version to 6.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@daniellansun
daniellansun committed Mar 11, 2018
1 parent 3eb491c commit b3e0421
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ configurations {

ext {
antVersion = '1.10.1'
asmVersion = '6.0'
asmVersion = '6.1'
antlrVersion = '2.7.7'
bridgerVersion = '1.1.Final'
coberturaVersion = '1.9.4.1'
Expand Down

6 comments on commit b3e0421

@henrik242
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielsun1106 When can we expect 2.5.0-rc-1 with this asm change? I was hoping for a Greach release.. :)

@daniellansun
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is up to Paul's plan ;-)

@henrik242
Copy link

@henrik242 henrik242 commented on b3e0421 Mar 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielsun1106 His Divine Plan, okay :) ( ping @paulk-asert )

Also, will the asm upgrade reach the GROOVY_2_4_X branch? That would help for jdk10 compat in e.g. Gradle, who are still on 2.4.x.

@paulk-asert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to hear latest status of releases etc., the Apache Groovy dev list is a good one to subscribe to.

wrt asm library - last upgrade of ASM on 2_4_X still has issues, e.g.:
https://issues.apache.org/jira/browse/GROOVY-8508
https://issues.apache.org/jira/browse/GROOVY-8494
Fixing that may yet require revert of ASM version. But if we manage to fix it without reverting, we can consider another upgrade of ASM. We tend not bump dependency versions in point releases without a good reason.

@henrik242
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulk-asert Thanks! Given that the jdk10 release is just around the corner I hope the asm upgrade goes through.

@daniellansun
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulk-asert asm has been downgraded for the time being:
82c0cf6

Please sign in to comment.