GROOVY-7909 Calling parents method from trait using Parent.super.method() fail depending on trait declaration order #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,57 @@ | |||
| package groovy.bugs | |||
There was a problem hiding this comment.
Could you add the license header to this file, should be able to grab it from another file in the same package.
There was a problem hiding this comment.
It has been added.
| /** | ||
| * This transformer is used to transform calls to <code>SomeTrait.super.foo()</code> into the appropriate trait call. | ||
| * | ||
| * @author Cédric Champeau | ||
| * @since 2.3.0 | ||
| */ | ||
| class SuperCallTraitTransformer extends ClassCodeExpressionTransformer { | ||
| public static final String UNRESOLVED_HELPER_CLASS = "UNRESOLVED_HELPER_CLASS"; |
There was a problem hiding this comment.
This is only used in the same package, I think package-private would be better than public.
There was a problem hiding this comment.
Yes, I haven't realize it. Done as you say.
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2017
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.