Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18197. Protobuf-Java 3.21.12 #26

Merged
merged 5 commits into from Jan 11, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jan 4, 2024

Fix merge conflicts in #19 and use slightly newer version of Protobuf-Java (most recent in 3.21 line).

fyi @steveloughran

steveloughran and others added 5 commits October 10, 2022 14:38
This patch bumps up the protobuf version so that Hadoop
is not a vulnerable to CVE-2021-22569.

I'm not renaming the module hadoop-shaded-protobuf_3_7
because that significantly complicates imports/upgrading.
That said, I don't see why the version number needed to be
included there. We will have to live with that.

This also fixes up the parent POM references in the child modules
as IntelliJ requires a full path.

Testing: needs to go through hadoop built with the updated jar and
with its own protobuf version marker updated.
Verified hadoop compiles on a macbook m1.
@pjfanning pjfanning changed the title Protobuf-Java 3.21.12 HADOOP-18197. Protobuf-Java 3.21.12 Jan 4, 2024
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@steveloughran steveloughran merged commit df92347 into apache:trunk Jan 11, 2024
3 checks passed
@pjfanning pjfanning deleted the protobuf-3.21.12 branch January 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants