Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16496. Apply HDDS-1870 (ConcurrentModification at PrometheusMe… #1317

Closed
wants to merge 1 commit into from

Conversation

aajisaka
Copy link
Member

…tricsSink) to Hadoop common.

JIRA: https://issues.apache.org/jira/browse/HADOOP-16496
Ref: #1179

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1261 trunk passed
+1 compile 1030 trunk passed
+1 checkstyle 45 trunk passed
+1 mvnsite 76 trunk passed
+1 shadedclient 866 branch has no errors when building and testing our client artifacts.
+1 javadoc 63 trunk passed
0 spotbugs 124 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 121 trunk passed
_ Patch Compile Tests _
+1 mvninstall 47 the patch passed
+1 compile 1023 the patch passed
+1 javac 1023 the patch passed
+1 checkstyle 46 the patch passed
+1 mvnsite 78 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 735 patch has no errors when building and testing our client artifacts.
+1 javadoc 62 the patch passed
+1 findbugs 130 the patch passed
_ Other Tests _
+1 unit 552 hadoop-common in the patch passed.
+1 asflicense 44 The patch does not generate ASF License warnings.
6293
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/1/artifact/out/Dockerfile
GITHUB PR #1317
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 753fb0ac0cab 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4f925af
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/1/testReport/
Max. process+thread count 1405 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

@bharatviswa504 would you review this? This issue is Hadoop common side of #1179, which you reviewed.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 49 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 355 root in trunk failed.
+1 compile 1074 trunk passed
+1 checkstyle 35 trunk passed
+1 mvnsite 68 trunk passed
+1 shadedclient 727 branch has no errors when building and testing our client artifacts.
+1 javadoc 55 trunk passed
0 spotbugs 110 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 107 trunk passed
_ Patch Compile Tests _
+1 mvninstall 44 the patch passed
+1 compile 1050 the patch passed
+1 javac 1050 the patch passed
+1 checkstyle 40 the patch passed
+1 mvnsite 66 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 609 patch has no errors when building and testing our client artifacts.
+1 javadoc 56 the patch passed
+1 findbugs 126 the patch passed
_ Other Tests _
-1 unit 508 hadoop-common in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
5096
Reason Tests
Failed junit tests hadoop.ipc.TestIPC
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/2/artifact/out/Dockerfile
GITHUB PR #1317
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e47e1c382f5b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6244502
Default Java 1.8.0_212
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/2/artifact/out/branch-mvninstall-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/2/testReport/
Max. process+thread count 1497 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1317/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Thank You @aajisaka for the fix.

@aajisaka aajisaka closed this in 30ce854 Aug 21, 2019
@aajisaka aajisaka deleted the HADOOP-16496 branch August 21, 2019 01:11
@aajisaka
Copy link
Member Author

Committed to trunk. Thanks @bharatviswa504 for the review!

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
…tricsSink) to Hadoop common.

This closes apache#1317

Reviewed-by: Bharat Viswanadham <bharat@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants