Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1808. TestRatisPipelineCreateAndDestory times out #1338

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  • Increase timeout of the test cases (both of them are prone to intermittent timeout). Rationale: (1) there is already a timeout on waitForPipelines(), which was increased in 0d62753da96 without increasing overall test timeout, (2) test timeout needs to account for mini cluster startup.
  • Fix typo in class name.

https://issues.apache.org/jira/browse/HDDS-1808

How was this patch tested?

Ran the test several times. It passed in all cases. It took as long as 77 seconds in one case, so one of the two test cases would have failed with the original 30 second timeout.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Aug 22, 2019
@adoroszlai
Copy link
Contributor Author

@bshashikant please review

[INFO] Running org.apache.hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 82.355 s - in org.apache.hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 104 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 722 trunk passed
+1 compile 410 trunk passed
+1 checkstyle 84 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1041 branch has no errors when building and testing our client artifacts.
+1 javadoc 203 trunk passed
0 spotbugs 474 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 713 trunk passed
_ Patch Compile Tests _
+1 mvninstall 569 the patch passed
+1 compile 425 the patch passed
+1 javac 425 the patch passed
+1 checkstyle 77 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 781 patch has no errors when building and testing our client artifacts.
+1 javadoc 198 the patch passed
+1 findbugs 737 the patch passed
_ Other Tests _
+1 unit 397 hadoop-hdds in the patch passed.
-1 unit 1517 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
8179
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestContainerStateMachineFailures
hadoop.ozone.client.rpc.Test2WayCommitInRatis
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1338/1/artifact/out/Dockerfile
GITHUB PR #1338
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 8f59d091f747 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 28fb4b5
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1338/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1338/1/testReport/
Max. process+thread count 3590 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1338/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor

Thank You @adoroszlai for the fix.
I have committed this to the trunk.

@bharatviswa504 bharatviswa504 merged commit f6af7d0 into apache:trunk Aug 23, 2019
@adoroszlai adoroszlai deleted the HDDS-1808 branch August 23, 2019 08:59
@adoroszlai
Copy link
Contributor Author

Thanks @bharatviswa504 for reviewing and committing it.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants