New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts #1348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elek for all the improvements.
|
||
for FAILURE in $FAILURES; do | ||
TEST_RESULT_LOCATION="$(realpath --relative-to="$REPORT_DIR" "$TEST_RESULT_FILE")" | ||
TEST_OUTPUT_LOCATION="${TEST_RESULT_LOCATION//.txt/-output.txt/}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST_OUTPUT_LOCATION="${TEST_RESULT_LOCATION//.txt/-output.txt/}" | |
TEST_OUTPUT_LOCATION="${TEST_RESULT_LOCATION//.txt/-output.txt}" |
find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; | ||
|
||
## Add the tests where the JVM is crashed | ||
grep -A1 'Crashed tests' ${REPORT_DIR}/output.log \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shellcheck:26: note: Double quote to prevent globbing and word splitting. [SC2086]
💔 -1 overall
This message was automatically generated. |
|
||
#Copy heap dump and dump leftovers | ||
find "." -name "*.hprof" -exec cp {} "$REPORT_DIR/" \; | ||
find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also copy *.dumpstream
, which may help finding out the cause of Corrupted STDOUT
warning of forked JVM.
find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; | |
find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; | |
find "." -name "*.dumpstream" -exec cp {} "$REPORT_DIR/" \; |
http://maven.apache.org/surefire/maven-surefire-plugin/faq.html#dumpfiles
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
💔 -1 overall
This message was automatically generated. |
+1, committed to the trunk. Thanks for the contributions, @elek and @adoroszlai |
hadoop-ozone/dev-support/checks directory contains shell scripts to execute different type of code checks (findbugs, checkstyle, etc.)
Currently the contract is very simple. Every shell script executes one (and only one) check and the shell response code is set according to the result (non-zero code if failed).
To have better reporting in the github pr build, it would be great to improve the scripts to generate simple summary files and save the relevant files for archiving.
See: https://issues.apache.org/jira/browse/HDDS-2030