You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line 839 of NNStroage.java#reportErrorsOnDirectories, the synchronized list, sds
is iterated in an unsynchronized manner, but according to Oracle Java 7 API specification,
this is not thread-safe and can lead to non-deterministic behavior.
This pull request adds a fix by synchronizing the iteration on sds. The synchronized list is passed to method reportErrorsOnDirectories from here
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1136
trunk passed
+1
compile
61
trunk passed
+1
checkstyle
41
trunk passed
+1
mvnsite
65
trunk passed
+1
shadedclient
735
branch has no errors when building and testing our client artifacts.
+1
javadoc
46
trunk passed
0
spotbugs
164
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
161
trunk passed
_ Patch Compile Tests _
+1
mvninstall
59
the patch passed
+1
compile
58
the patch passed
+1
javac
58
the patch passed
+1
checkstyle
36
the patch passed
+1
mvnsite
63
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
701
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1033
trunk passed
+1
compile
61
trunk passed
+1
checkstyle
44
trunk passed
+1
mvnsite
64
trunk passed
+1
shadedclient
766
branch has no errors when building and testing our client artifacts.
+1
javadoc
45
trunk passed
0
spotbugs
159
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
157
trunk passed
_ Patch Compile Tests _
+1
mvninstall
56
the patch passed
+1
compile
54
the patch passed
+1
javac
54
the patch passed
+1
checkstyle
36
the patch passed
+1
mvnsite
58
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
671
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1085
trunk passed
+1
compile
62
trunk passed
+1
checkstyle
41
trunk passed
+1
mvnsite
69
trunk passed
+1
shadedclient
701
branch has no errors when building and testing our client artifacts.
+1
javadoc
46
trunk passed
0
spotbugs
162
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
160
trunk passed
_ Patch Compile Tests _
+1
mvninstall
61
the patch passed
+1
compile
56
the patch passed
+1
javac
56
the patch passed
+1
checkstyle
34
the patch passed
+1
mvnsite
60
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
663
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1348
trunk passed
+1
compile
73
trunk passed
+1
checkstyle
46
trunk passed
+1
mvnsite
72
trunk passed
+1
shadedclient
872
branch has no errors when building and testing our client artifacts.
+1
javadoc
54
trunk passed
0
spotbugs
180
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
178
trunk passed
_ Patch Compile Tests _
+1
mvninstall
67
the patch passed
+1
compile
59
the patch passed
+1
javac
59
the patch passed
+1
checkstyle
41
the patch passed
+1
mvnsite
67
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
809
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1119
trunk passed
+1
compile
55
trunk passed
+1
checkstyle
40
trunk passed
+1
mvnsite
62
trunk passed
+1
shadedclient
701
branch has no errors when building and testing our client artifacts.
+1
javadoc
46
trunk passed
0
spotbugs
164
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
161
trunk passed
_ Patch Compile Tests _
+1
mvninstall
59
the patch passed
+1
compile
56
the patch passed
+1
javac
56
the patch passed
+1
checkstyle
39
the patch passed
+1
mvnsite
62
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
727
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1137
trunk passed
+1
compile
58
trunk passed
+1
checkstyle
41
trunk passed
+1
mvnsite
63
trunk passed
+1
shadedclient
727
branch has no errors when building and testing our client artifacts.
+1
javadoc
45
trunk passed
0
spotbugs
151
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
149
trunk passed
_ Patch Compile Tests _
+1
mvninstall
57
the patch passed
+1
compile
52
the patch passed
+1
javac
52
the patch passed
+1
checkstyle
35
the patch passed
+1
mvnsite
56
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
685
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1071
trunk passed
+1
compile
55
trunk passed
+1
checkstyle
36
trunk passed
+1
mvnsite
57
trunk passed
+1
shadedclient
708
branch has no errors when building and testing our client artifacts.
+1
javadoc
47
trunk passed
0
spotbugs
164
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
163
trunk passed
_ Patch Compile Tests _
+1
mvninstall
61
the patch passed
+1
compile
56
the patch passed
+1
javac
56
the patch passed
+1
checkstyle
38
the patch passed
+1
mvnsite
74
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
700
patch has no errors when building and testing our client artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line 839 of NNStroage.java#reportErrorsOnDirectories, the synchronized list,
sds
is iterated in an unsynchronized manner, but according to Oracle Java 7 API specification,
this is not thread-safe and can lead to non-deterministic behavior.
This pull request adds a fix by synchronizing the iteration on
sds
. The synchronized list is passed to methodreportErrorsOnDirectories
from here