HDDS-2098 : Ozone shell command prints out ERROR when the log4j file …

[avijayanhwx]

…is not present.

Manually tested change on cluster.

[avijayanhwx]

/label ozone

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	108	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	724	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	896	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	616	the patch passed
+1	mvnsite	0	the patch passed
-1	shellcheck	33	The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	770	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	112	hadoop-hdds in the patch passed.
+1	unit	297	hadoop-ozone in the patch passed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		3806

Subsystem	Report/Notes
Docker	Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/artifact/out/Dockerfile
GITHUB PR	#1411
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 5ce4281a3c08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b15c116
shellcheck	https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/artifact/out/diff-patch-shellcheck.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/testReport/
Max. process+thread count	306 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common U: hadoop-ozone/common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	605	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	880	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	565	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	32	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	768	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	108	hadoop-hdds in the patch passed.
+1	unit	290	hadoop-ozone in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		3560

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/artifact/out/Dockerfile
GITHUB PR	#1411
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 075bdf979e4e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / bb0b922
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/testReport/
Max. process+thread count	310 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common U: hadoop-ozone/common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bharatviswa504]

I have a question
During ozone tarball build, we do copy ozone-shell-log4j.properties to etc/hadoop (like we copy log4.properties then why do we see this error or something need to be fixed in copying this script?

https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/dist/dev-support/bin/dist-layout-stitching#L95

[avijayanhwx]

I have a question
During ozone tarball build, we do copy ozone-shell-log4j.properties to etc/hadoop (like we copy log4.properties then why do we see this error or something need to be fixed in copying this script?

https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/dist/dev-support/bin/dist-layout-stitching#L95

Yes, while starting ozone from snapshot tar ball, it works perfectly. However, when Ozone is deployed through a cluster management tool like Cloudera Manager, the log4j properties may not be individually configurable. We may have to rely on a default log4.properties. In that case, printing a FileNotFoundException for ozone shell commands is something we can avoid.

[adoroszlai]

Thanks for fixing this @avijayanhwx.

[bharatviswa504]

+1.
It is fine to commit this, as we are using log4j.properties only when shell-log4j.properties file is available.