Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2168. TestOzoneManagerDoubleBufferWithOMResponse sometimes fails… #1509

Merged
merged 1 commit into from Sep 24, 2019

Conversation

vivekratnavel
Copy link
Contributor

… with out of memory error

After debugging this issue with @avijayanhwx and @bharatviswa504 , found out that mockito was the culprit here by consuming lots of heap memory to store the invocations.

Thanks to @avijayanhwx and @bharatviswa504 for helping!

@vivekratnavel
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Sep 23, 2019
@vivekratnavel
Copy link
Contributor Author

@bharatviswa504 @avijayanhwx Please review

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 176 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
-1 mvninstall 73 hadoop-hdds in trunk failed.
-1 mvninstall 38 hadoop-ozone in trunk failed.
-1 compile 23 hadoop-hdds in trunk failed.
-1 compile 16 hadoop-ozone in trunk failed.
+1 checkstyle 86 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1207 branch has no errors when building and testing our client artifacts.
-1 javadoc 27 hadoop-hdds in trunk failed.
-1 javadoc 20 hadoop-ozone in trunk failed.
0 spotbugs 1318 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 40 hadoop-hdds in trunk failed.
-1 findbugs 20 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 37 hadoop-hdds in the patch failed.
-1 mvninstall 30 hadoop-ozone in the patch failed.
-1 compile 26 hadoop-hdds in the patch failed.
-1 compile 25 hadoop-ozone in the patch failed.
-1 javac 26 hadoop-hdds in the patch failed.
-1 javac 25 hadoop-ozone in the patch failed.
+1 checkstyle 66 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 799 patch has no errors when building and testing our client artifacts.
-1 javadoc 18 hadoop-hdds in the patch failed.
-1 javadoc 17 hadoop-ozone in the patch failed.
-1 findbugs 28 hadoop-hdds in the patch failed.
-1 findbugs 16 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 25 hadoop-hdds in the patch failed.
-1 unit 20 hadoop-ozone in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2967
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/Dockerfile
GITHUB PR #1509
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 9c8ef3ecc37d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6cbe5d3
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1509/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@avijayanhwx
Copy link
Contributor

LGTM +1

@vivekratnavel
Copy link
Contributor Author

The integration test failures are not related to the patch.

@bharatviswa504 bharatviswa504 merged commit a346381 into apache:trunk Sep 24, 2019
@bharatviswa504
Copy link
Contributor

I have committed this to trunk.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants