HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
💔 -1 overall
This message was automatically generated. |
|
The test failures are not related, however, I realized I missed updating the delete path for S3 / Multipart. I will push updates shortly to this PR. |
dineshchitlangia
force-pushed
the
HDDS-2174
branch
from
4ea3fab
to
4098abb
Compare
|
/retest |
dineshchitlangia
force-pushed
the
HDDS-2174
branch
from
4098abb
to
f145db6
Compare
|
/retest |
|
💔 -1 overall
This message was automatically generated. |
| */ | ||
| public static String getDeletedKeyName(String key, long timestamp) { | ||
| return key + "_" + timestamp; | ||
| public static RepeatedOmKeyInfo stripGdprMetadata( |
There was a problem hiding this comment.
Can you add javadoc for this?
There was a problem hiding this comment.
Thanks for checking @bharatviswa504 . I have updated PR to address this and also renamed the method appropriately while I was writing the javadoc.
|
💔 -1 overall
This message was automatically generated. |
dineshchitlangia
force-pushed
the
HDDS-2174
branch
from
f145db6
to
aa197dd
Compare
|
/retest |
|
💔 -1 overall
This message was automatically generated. |
| * @return Deleted key name | ||
| * Prepares key info to be moved to deletedTable. | ||
| * 1. It strips GDPR metadata from key info | ||
| * 2. Check if an entry exists in deletedTable for given objectKey, if yes, |
There was a problem hiding this comment.
The 2nd point should be updated, it is still mentioning about old logic
|
bharatviswa504
approved these changes
Sep 25, 2019
|
💔 -1 overall
This message was automatically generated. |
…eted HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted addressed checkstyle violations HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted addressed review comments
…eted Addressed review comment to rectify javadoc
dineshchitlangia
force-pushed
the
HDDS-2174
branch
from
3ceeb03
to
301d0a8
Compare
|
💔 -1 overall
This message was automatically generated. |
anuengineer
approved these changes
Sep 26, 2019
|
Thank you for the contribution. I have committed this patch to the trunk. |
|
Thank you @anuengineer for review/commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As advised, deleted GDPR related metadata from KeyInfo before moving it to deletedTable.
Added/updated test.
P.S. The changes in KeyManagerImpl are not really needed but made them for sanity & it is no harm.