HDDS-2180. Add Object ID and update ID on VolumeList Object. #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Sep 25, 2019
| @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList volumeList, | |||
| } | |||
|
|
|||
| List<String> prevVolList = new ArrayList<>(); | |||
| long objectID = 100; | |||
There was a problem hiding this comment.
Is there a reason for initialize objectID to 100 here for new volume?
There was a problem hiding this comment.
No, thanks I will fix that, I discovered it from a test code path, and left over from the fix. I will get this fixed.
xiaoyuyao
reviewed
Sep 25, 2019
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 25, 2019
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
nandakumar131
approved these changes
Sep 26, 2019
|
Was this committed without a pre-commit run from Anzix? |
Looks like it was not run. I did look at the yetus output but the output is too noisy to make any sense. Is this commit causing any issues ? |
|
None that I know of. However we should not commit a patch without CI on principle. |
This has been broken for quite a while; So I rely on Jenkins/Yetus and hand building before apply the commits. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-2180
Adds Object ID and Update ID to VolumeList object.