Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2185. createmrenv failure not reflected in acceptance test result #1533

Closed
wants to merge 1 commit into from

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Sep 26, 2019

What changes were proposed in this pull request?

Avoid purging results dir when testlib.sh is sourced. Explicitly do that during docker env startup.

https://issues.apache.org/jira/browse/HDDS-2185

How was this patch tested?

Ran ozone-mr/hadoop31 test, verified that robot-hadoop31-hadoop31-createmrenv-scm.xml is present along with other results.

Note that with this change, acceptance tests are expected to be failing. They should have been failing with HDDS-2187 since HDDS-2101 was merged. They are being fixed in #1537.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Sep 26, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 75 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 46 hadoop-hdds in trunk failed.
-1 mvninstall 30 hadoop-ozone in trunk failed.
+1 mvnsite 0 trunk passed
+1 shadedclient 884 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
-1 mvninstall 36 hadoop-hdds in the patch failed.
-1 mvninstall 29 hadoop-ozone in the patch failed.
+1 mvnsite 0 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 795 patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 unit 26 hadoop-hdds in the patch failed.
-1 unit 22 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
2109
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/Dockerfile
GITHUB PR #1533
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux 5e40d1cf924d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a3f6893
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/testReport/
Max. process+thread count 294 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1533/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai
Copy link
Contributor Author

@elek please review

@elek
Copy link
Member

elek commented Sep 27, 2019

@elek please review

🔭

@elek elek closed this in a93a139 Sep 27, 2019
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks the fix @adoroszlai

@adoroszlai adoroszlai deleted the HDDS-2185 branch September 28, 2019 05:39
@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants