HDDS-2140. Add robot test for GDPR feature #1542
Conversation
|
/label ozone |
|
@elek Request your review pls. Thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
Failures are unrelated to the patch. |
There was a problem hiding this comment.
Thanks @dineshchitlangia the patch. Overall it looks good to me I have one comment about the impotency.
Unrelated to this patch (as this patch tests the CLI arguments) but I am wondering how the core GDPR feature can be tested. I mean how can we be sure that the data is really unreadable (grep to the chunk files for a specific strings??). To be honest, I have no idea, but putting this interesting question to here ;-)
|
|
||
| *** Test Cases *** | ||
| Test GDPR(disabled) without explicit options | ||
| Execute ozone sh volume create /${volume} --quota 100TB |
There was a problem hiding this comment.
Usually I prefer to make the robot tests idempotent. I think it's better to support to run them multiple times and it more safe if we use brand new volume all the time. In ozone-shell it's solved by adding a random string to all the volume names.
*** Variables ***
${prefix} generated
*** Keywords ***
Generate prefix
${random} = Generate Random String 5 [NUMBERS]
Set Suite Variable ${prefix} ${random}
*** Test Cases ***
RpcClient with port
Test ozone shell o3:// om:9862 ${prefix}-rpcwoport
There was a problem hiding this comment.
Introduced random volume name in recent commit.
Recap: GDPR talk in Vegas ;)
After our Vegas conference, we modified the delete path (HDDS-2174):
|
|
💔 -1 overall
This message was automatically generated. |
Yes, I understand. That's the question. How can we prove that we only have junk. I would like to prove that the junk is encrypted. |
There was a problem hiding this comment.
+1 Thanks the update @dineshchitlangia
Tested (twice!) and worked well.
One thing what I found, I think it's not yet enabled in the daily builds.
I think in the hadoop-ozone/dist/src/main/compose/ozone/test.sh we need a new line:
execute_robot_test gdpr.robot
But let's do it in a follow-up jira. To many issues in the queue. I will commit it right now...
@elek Such a test exists in UT at TestOzoneRpcClientAbstract#testKeyReadWriteForGDPR |
Wow, and with perfect java description. Yes, it's exactly that. It's my shame that I didn't know. You deserve a photo with this source code: ;-) |
Thanks, because it was a complex test and I wanted to ensure that no one accidentally modifies the test without getting the context, I made it so descriptive. Glad it looks good and helps. Good Idea, I will get a pic like that 😄 |
Addressed this in HDDS-2252 |
Tested using test-single script.