HDDS-2265. integration.sh may report false negative #1608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
💔 -1 overall
This message was automatically generated. |
|
@elek please review (let me know if I should retest until we hit the case when integration test gets killed) |
anuengineer
reviewed
Oct 7, 2019
| @@ -45,6 +45,11 @@ grep -A1 'Crashed tests' "${REPORT_DIR}/output.log" \ | |||
| | cut -f2- -d' ' \ | |||
| | sort -u >> "${REPORT_DIR}/summary.txt" | |||
|
|
|||
| ## Check if Maven was killed | |||
| if grep -q 'Killed.* mvn .* test ' "${REPORT_DIR}/output.log"; then | |||
There was a problem hiding this comment.
So we are presuming that Killed will never be used by a test? :) I am fine with that.
+1. LGTM.
elek
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
+1 Thanks the contribution @adoroszlai
Later we can improve it to collect all of the test names which are failing, but it's good enough to show the "JVM crash" type failures.
|
Thanks @anuengineer and @elek for reviewing, and @elek for committing it. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check if Maven was killed during test run (observable in integration test runs). If so, mention it in
summary.txt. Non-emptysummary.txtis handled as "failure".https://issues.apache.org/jira/browse/HDDS-2265
How was this patch tested?
Tested both positive and negative case:
summary.txtremains emptymvnprocess, verified thatsummary.txtcontains the expected line