HADOOP-16640. WASB: Override getCanonicalServiceName() to return URI #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… url of WASB filesystem
|
+1 |
|
🎊 +1 overall
This message was automatically generated. |
|
WASB tests passed: |
|
If you return a non-null value from this method, you are telling callers that you will will be issuing a delegation token, that is getDelegationToken() is non-null Is that your intent? if so then you don't need an extra option for it -just ask whatever issues DTs for the FS if it has a DT or is willing to issue one. |
|
@steveloughran Here is the issue reported by wasb customer: BTW, from the documentation, this API should only be used by token cache but not others, so it seem HBase should not rely on this call to do the check? |
|
@steveloughran does it look good to you? |
| }); | ||
|
|
||
| // clear fs cache | ||
| FileSystem.closeAll(); |
There was a problem hiding this comment.
you don't need to do that , just call FileSystem.newInstance(defaultURI, conf), remembering to close the new FS afterwards
|
small change to the tests proposed, but LGTM. I do worry that a lot of the abfs config is hidden in the javadocs. Someone should fix that with more user docs. I know its not that relevant for managed cluster deployments (HD/I etc), but for people talking to abfs externally, it really matters. |
DadanielZ
force-pushed
the
HADOOP-16640
branch
from
2c9b556
to
3cd0418
Compare
|
Sure, I've added HADOOP-16659 for work on adding the missing docs for the abfs/wasb config. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
committed, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration to override getCanonicalServiceName() to return URI of WASB FS.