Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPREDUCE-7247. Modify HistoryServerRest.html content,change The job attempt id‘s datatype from string to int #1684

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

kevinzhao1661
Copy link
Contributor

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 mvninstall 1092 trunk passed
+1 mvnsite 33 trunk passed
+1 shadedclient 1891 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 28 the patch passed
+1 mvnsite 26 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 799 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 asflicense 33 The patch does not generate ASF License warnings.
2930
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1684/1/artifact/out/Dockerfile
GITHUB PR #1684
Optional Tests dupname asflicense mvnsite
uname Linux afad35e8bccb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 012756a
Max. process+thread count 452 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1684/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM
Thanks for @kevinzhao1661 contributing.

@aajisaka aajisaka self-requested a review January 16, 2020 03:48
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. +1.

@aajisaka aajisaka changed the title MAPREDUCE-7247. Modify HistoryServerRest.html content,change The job attempt id‘s datatype from string to int MAPREDUCE-7247. Change the job attempt id‘s datatype from string to int in HistoryServerRest.html Jan 16, 2020
@aajisaka aajisaka merged commit b8518e6 into apache:trunk Jan 16, 2020
@aajisaka
Copy link
Member

Thanks @kevinzhao1661 for the contribution and thanks @jiwq for the review.

@aajisaka
Copy link
Member

Hi @kevinzhao1661 , what is your id in ASF JIRA? I'd like to assign you to https://issues.apache.org/jira/browse/MAPREDUCE-7247

@aajisaka aajisaka changed the title MAPREDUCE-7247. Change the job attempt id‘s datatype from string to int in HistoryServerRest.html MAPREDUCE-7247. Modify HistoryServerRest.html content,change The job attempt id‘s datatype from string to int Jan 16, 2020
aajisaka pushed a commit that referenced this pull request Jan 16, 2020
…attempt id‘s datatype from string to int (#1684)

(cherry picked from commit b8518e6)
aajisaka pushed a commit that referenced this pull request Jan 16, 2020
…attempt id‘s datatype from string to int (#1684)

(cherry picked from commit b8518e6)
aajisaka pushed a commit that referenced this pull request Jan 16, 2020
…attempt id‘s datatype from string to int (#1684)

(cherry picked from commit b8518e6)
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 2, 2020
…attempt id‘s datatype from string to int (apache#1684)

(cherry picked from commit b8518e6)
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 3, 2020
…attempt id‘s datatype from string to int (apache#1684)

(cherry picked from commit b8518e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants